OCPBUGS-62173: Add TLS config observer to update opcon/catd by tmshort · Pull Request #145 · openshift/cluster-olm-operator

tmshort · 2025-10-22T16:00:30Z

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

--tls-custom-ciphers=X,Y,Z
--tls-custom-version=N
--tls-profile=custom

In addition:

Update library-go to include the TLS config observer
Move the deployment update hooks (proxy, TLS) into their own files
Add unit tests
Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short todd.short@me.com
Co-Authored-By: Claude noreply@anthropic.com

openshift-ci-robot · 2025-10-22T16:00:41Z

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add an apiserver TLS config observer. This examines TLS config and copies the values into the .spec.observedConfig field of the olms.operator.openshift.io/cluster resource. This is then used to apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

--tls-custom-ciphers=X,Y,Z

--tls-custom-version=N

--tls-profile=custom

In addition:

Update library-go to include the TLS config observer

Move the deployment update hooks (proxy, TLS) into their own files

Add unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-22T16:01:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-10-22T16:08:32Z

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

--tls-custom-ciphers=X,Y,Z

--tls-custom-version=N

--tls-profile=custom

In addition:

Update library-go to include the TLS config observer

Move the deployment update hooks (proxy, TLS) into their own files

Add unit tests

Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short todd.short@me.com
Co-Authored-By: Claude noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2025-10-22T18:10:45Z

/test openshift-e2e-aws
/test openshift-e2e-aws-techpreview

camilamacedo86 · 2025-10-23T10:47:32Z

/retest-required

Add an apiserver TLS config observer. This examines TLS config and copies the values into the .spec.observedConfig field of the olms.operator.openshift.io/cluster resource. This is then used to apply configuration to the operator-controller and catalogd. The configuration is applied to those deployments via: * --tls-custom-ciphers=X,Y,Z * --tls-custom-version=N * --tls-profile=custom In addition: * Move the deployment update hooks (proxy, TLS) into their own files * Add unit tests * Changed Apply()s to Patch()s when modifying olms to avoid overwrites * Update fieldManagers to avoid overwrites Signed-off-by: Todd Short <todd.short@me.com> Co-Authored-By: Claude <noreply@anthropic.com>

tmshort · 2025-10-23T17:31:13Z

openshift-e2e-aws-devpreview is failing with this:

: [sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it [Suite:openshift/conformance/parallel/minimal]

Which seems unrelated. After approvals, I will re-run it, but I may override it.

tmshort · 2025-10-23T17:56:16Z

/test openshift-e2e-aws-devpreview

openshift-ci · 2025-10-23T20:43:27Z

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`de8017a`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jianzhangbjz · 2025-10-28T00:47:28Z

I guess it supersedes #143

jianzhangbjz · 2025-10-28T03:31:11Z

Test passed. Details: https://issues.redhat.com/browse/OCPBUGS-62173
/verified by @jianzhangbjz
/lgtm

openshift-ci-robot · 2025-10-28T03:31:22Z

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

Details

In response to this:

Test passed. Details: https://issues.redhat.com/browse/OCPBUGS-62173
/verified by @jianzhangbjz
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-28T03:36:26Z

@tmshort: Jira Issue Verification Checks: Jira Issue OCPBUGS-62173
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62173 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

--tls-custom-ciphers=X,Y,Z

--tls-custom-version=N

--tls-profile=custom

In addition:

Update library-go to include the TLS config observer

Move the deployment update hooks (proxy, TLS) into their own files

Add unit tests

Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short todd.short@me.com
Co-Authored-By: Claude noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-10-30T12:59:17Z

Fix included in accepted release 4.21.0-0.nightly-2025-10-30-060549

openshift-ci bot requested review from LalatenduMohanty and ankitathomas October 22, 2025 16:01

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025

tmshort force-pushed the tlsprofiles3 branch from 1915a97 to 2631a97 Compare October 22, 2025 16:07

tmshort force-pushed the tlsprofiles3 branch 2 times, most recently from 95cfa2b to 642bcb0 Compare October 22, 2025 20:50

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025

tmshort force-pushed the tlsprofiles3 branch from 642bcb0 to de8017a Compare October 23, 2025 14:23

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 28, 2025

openshift-ci bot assigned jianzhangbjz Oct 28, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025

openshift-merge-bot bot merged commit 39ffd1b into openshift:main Oct 28, 2025
11 of 12 checks passed

tmshort deleted the tlsprofiles3 branch November 17, 2025 17:02

Conversation

tmshort commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 22, 2025

Uh oh!

openshift-ci bot commented Oct 22, 2025

Uh oh!

openshift-ci-robot commented Oct 22, 2025

Uh oh!

tmshort commented Oct 22, 2025

Uh oh!

camilamacedo86 commented Oct 23, 2025

Uh oh!

tmshort commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmshort commented Oct 23, 2025

Uh oh!

openshift-ci bot commented Oct 23, 2025

Uh oh!

jianzhangbjz commented Oct 28, 2025

Uh oh!

jianzhangbjz commented Oct 28, 2025

Uh oh!

openshift-ci-robot commented Oct 28, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 28, 2025

Uh oh!

openshift-merge-robot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tmshort commented Oct 22, 2025 •

edited

Loading

tmshort commented Oct 23, 2025 •

edited

Loading